update return_per_1000
to return value in RAO
#213
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RPC call
delegateInfo.getDelegates
provides information for delegates.e.g.
The problem is that
return_per_1000
is 0 for most of the delegates.It's because the actual value is in the range of (0, 1).
Those delegates with
return_per_1000
> 1 are mostly weight copiers, who are not actually contributing to the network, but only trying to get rewarded.To fix this problem, I'd like to suggest updating
return_per_1000
to show the value in RAO(10^-9
TAO).That being said, this formula can be updated.
CURRENT:
return_per_1000 = emissions_per_day * 0.82 / (total_stake / 1000);
PROPOSED:
return_per_1000 = emissions_per_day * 0.82 / (total_stake / 1000) * 10 ^ 9
-->return_per_1000 = emissions_per_day * 0.82 / total_stake * 10 ^ 12
I've already tested this approach in our project and it works well. 😀